Research: segmented, resumable reloads (proof of concept) - #2251

CleanUpMap removed each player's neo_predicted_viewmodel_muzzleflash
but kept the neo_predicted_viewmodel it is parented to. A bot with a
pending class change calls RequestSetClass from CNEOBot::Spawn before
CBasePlayer::Spawn recreates the viewmodels, so GiveDefaultItems ->
Weapon_Switch dereferenced the removed muzzle flash viewmodel and the
server crashed (bot_changeclass, then mp_restartgame).

Preserve it like the viewmodel, so the player keeps one for life.

The Tachi and Milso viewmodels carry a node graph from HL2's pistol,
so a reload started from the lowered pose (during a sprint) played
the lowtoidle transition first. DefaultReload took that 0.37-0.40 s
transition as the reload length, and the server refilled the
magazine after about 0.6 s with no reload animation. Skip
transitions for ACT_VM_RELOAD as SetIdealActivity already does for
the draw, so the reload plays at once and lasts its own 2.1 s.

The Tachi and Milso viewmodels have an idle01empty sequence with the
slide held back, which neo never played: an emptied pistol held its
last fire frame for 2.0 s and then idled with the slide forward. The
original NEOTOKYO holds the slide back from the end of the last shot
until the reload. Send ACT_VM_IDLE_EMPTY for ACT_VM_IDLE while the
clip is empty, as the SDK crossbow does, and go to it as the emptying
shot's sequence ends. Models without the sequence are unchanged.

The Tachi and Milso viewmodels ship a drawempty sequence, the normal
draw with the slide held back, but it carries no activity, so an
empty pistol drew with the slide forward and only pulled it back as
the empty idle faded in. Pick drawempty by name in Deploy when the
clip is empty. Models without it, and loaded draws, are unchanged.

A reload credited the magazine only when the whole reload animation
ended, 0.2 to 0.7 s after the last click of the reload sound. Switching
weapons in that window dropped the reload, though the gun sounded done.

Each gun script now names its ReloadReadyTime: the last loud click of
its reload sound, rounded up to the animation frame. Where the charging
handle is home later (Jitte, SRM, MPN, AA13, PZ), the script comment
names that time as the alternative value. The reload completes there
and the rest of the animation plays on. Guns without the key (Supa7)
keep the animation length.

Move the player animation back onto CBasePlayerAnimState, the 2006
SDK base classic NEOTOKYO is built on, which neo compiles but did not
use. CNEOPlayerAnimState replaces CHL2MPPlayerAnimState and takes
CMultiPlayerAnimState out of the build (the files stay on disk).

The base gives classic's torso blend by speed, constant leg ground
speeds, the 3 s face-front timer and its feet rules. The new class
adds the run legs only while sprinting, the jump held until a drawn
landing, one gesture layer for fire, reload, grenade and detpack
events, the lean rule, the NeotokyoRebuild#2108 transitioner reset, and a face-front
timer counted from the last squared frame so server and client agree.
Client-side animation and the network excludes from NeotokyoRebuild#653 are kept.

Keep the end of the reload animation as the time the gun can fire
again, as before this branch, and only load the magazine early: the
owner stays busy until the animation ends, and the weapon loads the
magazine from ItemBusyFrame once the reload's ready time has passed.
A switch after the last click keeps the ammo; firing, aiming and the
sprint lower still wait for the animation to end.

The script key is now ReloadReadyBeforeEnd, the time from the last
reload click to the end of the reload animation, and the ready time is
that much before the end of the reload sequence actually played,
clamped to the reload start. The ready time is networked and predicted
so the client loads the magazine on the same frame.

Four entries, weapon_zr68.reload_{drop,seat,slap,bolt}, for the
per-phase reload pieces sliced from zr68_reload.wav (neoAssets
research-reload-phases 86ebd7f+). CHAN_ITEM, so a later piece from
the same weapon replaces an unfinished one. No code plays them yet.

A weapon script may list, per reload sequence, the phases the
sequence carries (drop, seat, slap, bolt), each with the time it
counts and the sound piece that goes with it, and whether a partial
reload keeps a chambered round. Data only: nothing reads it yet.

The ZR68S gets its block, generated from ntre's segments.csv for the
sequences in neoAssets research-reload-phases 86ebd7f.

A weapon whose script lists ReloadPhases reloads as a linear sequence
of phases instead of one refill at the end. The drop leaves only a
chambered round in the gun (the old magazine is gone), the seat loads
one magazine from the reserve, the bolt chambers a round on a dry
reload. A partial reload of a 30-round gun ends at 31.

The phases credited so far survive a weapon switch; once the weapon is
drawn again the reload resumes and credits only the phases left. Until
the resume sequences are selected, the shipped reload plays and the
earlier phases are skipped. The wait to fire stays the length of the
animation that plays. Weapons without the block (Supa7, SMAC, the
rest for now) take the previous path unchanged.

The ZR68S drops ReloadReadyBeforeEnd: its seat credit replaces it.

The resume sequences' reaches now keep the hand at the shipped reach
pace (neoAssets research-reload-phases b863e63), so each resume
credits its phases 0.5 s later than before.

A reload whose phases name sound pieces plays each piece when its
time in the playing sequence comes (each file starts 0.02 s before
its first transient), instead of the one reload wav at the start.
Phases credited before a switch do not play their pieces again, and a
switch stops the pieces still sounding. Also adds GetMaxRoundsInGun,
the magazine plus a chambered round, for the ammo HUD.

A weapon that keeps a round in the chamber on a partial reload shows
one more bullet slot, so a partial reload of a 30-round magazine reads
31/31. During a dry reload the last slot stays empty until the bolt
chambers a round.

The ZR68S script lists the phases of draw_resume_drop_{dry,partial}
(neoAssets research-reload-phases c61699a), the resume that starts
from the draw after the magazine dropped. A weapon may now list up to
12 reload sequences.

The drop piece now starts with the hand's first soft sounds (neoAssets
research-reload-phases c20c13b), so its first transient is at 0.146 s.

A reload with phases plays the sequence for what is left: the partial
reload when a round is chambered, and after a switch the resume that
starts with the hand reaching back to the next phase (from the drop,
the seat or the slap, dry or partial). After the magazine dropped,
the resume starts in the draw itself, which brings the fresh magazine
up out of view. A model without the sequence plays the shipped reload
and credits only the phases left, as before.

When the bullet row overflows into a + mark, the mark is filled for a
full gun; with the chambered round counted, full is the magazine plus
one.

The ZR68C reloads in phases like the ZR68S (same bones, same sound
pieces), with its sequences from neoAssets research-reload-phases
5edfe2e. Its ReloadReadyBeforeEnd goes: the seat credit replaces it.

The ZR68L reloads in phases with sequences and sound pieces from
neoAssets research-reload-phases d18409d; its own wav's pieces join
the sound script as weapon_zr68l.reload_{drop,seat,slap,bolt}. Its
ReloadReadyBeforeEnd goes: the seat credit replaces it.

Both MX guns reload in phases with the sequences and sound pieces of
neoAssets research-reload-phases 0c24082 (the seat rattle sounds at
the silent magazine seat, 0.27 s before its place in the wav); the
pieces join the sound script as weapon_mx.reload_*. Their
ReloadReadyBeforeEnd goes.

A phase may name sound2 / at2 beside sound / at, for a phase whose
sound comes in two pieces timed apart: the M41's seat has a tap
rattle that belongs at the silent seat and tap clicks that stay on
the tap.

The M41 guns reload in phases with the slap as its own phase, with
the sequences and sound pieces of neoAssets research-reload-phases
3e6d86e. The seat carries two pieces: the tap rattle at the silent
magazine seat and the tap clicks on the tap. Their
ReloadReadyBeforeEnd goes.

A phase's sound piece was only considered until the phase was
credited, so pieces timed after their credit (the M41's slap click,
its tap clicks) never played. Pieces now play on their own times;
those of phases credited before the sequence started, and a partial
reload's bolt, are marked done when the sequence starts.

Both Jitte guns reload in phases with the sequences and sound pieces
of neoAssets research-reload-phases d58ceec. Their ReloadReadyBeforeEnd
goes.

The SRM, SRM-S, MPN and unsilenced MPN reload in phases with the
sequences and sound pieces of neoAssets research-reload-phases f6e2f9e.
Their ReloadReadyBeforeEnd goes.

The AA13 and PZ reload in phases with the sequences and sound pieces
of neoAssets research-reload-phases b5aaa7a; the PZ's drum latch is its
slap phase. Their ReloadReadyBeforeEnd goes.

A resumed reload played the full reload gesture from the start, and a
partial or interrupted one let it run on past the reload. Send the
gesture's start cycle in the animation event's spare data (the credit
time of the last completed phase in the full reload, as a fraction of
it; 0 for a fresh reload and the draw-resume), and end the gesture
with PLAYERANIMEVENT_RELOAD_END when the reload ends, is holstered or
the weapon is dropped. The animation state starts the layer at that
cycle and resets the slot on the end event. No new networked fields.

The partial and resume sequences were looked up on the weapon entity,
which on the client carries the world model: the lookup failed there,
so the client predicted the shipped reload while the server played the
partial or resume sequence, and the resumed gesture started from 0 on
the owner's own client. Look them up, and time them, on the owner's
viewmodel on both sides.

The table index was sent in 4 signed bits (-8..7), but a gun has up to
12 tables and the ZR68, MX, M41 and PZ guns use index 8 for
draw_resume_drop_partial. The owner's client read another table, so it
predicted the wrong credits and replayed the drop sound piece on a
draw-resume after a partial reload's drop.

The tube's capacity was the clip size minus a live chambered round, so
the gun held 7 in all, as on master and in classic. The tube now holds
the script's clip size (7) and the chamber one more round beside it:
a partial reload ends at 8, a dry reload loads 7 and racks one up
(chamber + 6, 7 in all) with room for a one-shell top-off, and the
standalone rack is offered when the tube holds 7.

GetMaxRoundsInGun becomes virtual so the ammo HUD draws 8 slots for
the Supa7. GetMaxClip1 stays 7 (the tube) for bots and the base code,
as the magazine size does for the other chambered guns.

A dry reload switched away from before its end rack leaves shells in
the tube and the chamber empty. The trigger then fired anyway, and the
shot's own pump fed the tube's top shell, so that shot cost no round
(7 in the gun before and after). The trigger now racks the pump once
(the standalone rack) and the next press fires. Master and classic
fire at once in this state and pump on the next reload; this rack
only ever delays the shot, never brings it earlier.

A chambered slug blocked every shell reload, a rule from master's
single clip count, where the slug was simply the next round to fire.
With the chamber outside the tube, shells now load into the tube
behind a chambered slug and the reload ends without a rack, so a gun
with a slug up still tops off to 8. Loading a second slug onto a
chambered one stays refused, so a slug is never racked out by
accident.

The shot that emptied a Tachi or Milso played its normal fire sequence,
whose slide closes within 0.2 s, and the slide went back only when the
empty idle followed 0.4 s later. Both pistols ship a dry fire sequence
that is a shot's kick with the slide held back throughout, ending on
the empty idle's pose, so the last round's shot plays that instead.

A reload always played the reload sequence, whose slide is forward from
its first frame, so the slide of an empty pistol closed as the reload
began. The Milso ships a reload for an empty gun (ACT_VM_RELOAD_EMPTY)
that keeps the slide back until its release near the end, the same
length as the reload; an empty weapon now plays it where the model has
one.

# Conflicts:
#	src/game/shared/neo/weapons/weapon_neobasecombatweapon.cpp

anim-sdk-base deletes hl2mp_playeranimstate.*, where this branch had
the reload gesture hooks. They move to CNEOPlayerAnimState: the
RELOAD_END event, the resumed reload's start cycle from nData, and the
end of the reload gesture on RELOAD_END.

# Conflicts:
#	src/game/shared/hl2mp/hl2mp_playeranimstate.cpp
#	src/game/shared/hl2mp/hl2mp_playeranimstate.h

A dry Milso or Tachi reload interrupted after the seat has rounds in
the magazine but none chambered, and its slide is still back: the
resume is the slide release alone. The draw and the idle chose their
empty sequences by an empty magazine only, so the slide went forward
on the draw and snapped back when the release resumed.

The NEO anim state ends a gesture at once, so a reload cut short by a
partial magazine's end or a death snapped the third-person gun from
the reload pose to the aim pose in one frame. Fade it out over 0.2 s
as the HL2MP gesture slots did.

A switch mid-reload ended the third-person reload gesture at once, the
same snap from the reload pose to the aim pose that a reload ending
early had. Fade it out over 0.2 s too; a fire or throw gesture still
stops at once on a switch.

A gun with a chamber draws its magazine row and, at the row's right
end, one larger glyph for the chamber: lit while a live round is
chambered, in the empty color otherwise. The row's overflow mark now
counts the magazine alone. Number mode shows 29+1/30.

A trigger press during a reload with phases, while a round can fire,
ends the reload where it is and fires on the same tick: before the
old magazine drops it keeps the partly empty magazine, after the
fresh one is seated it keeps what was loaded. A dry reload before its
bolt, and a gun whose magazine is out, ignore the press. Sound pieces
of phases not reached stop; the first shot blends in with fire_blend
where the model has it. One entry point, TryFireDuringReload, called
from ItemBusyFrame; RELOAD_FIRE_INTERRUPTS turns it off.

With sv_neo_reload_chamber_shot on, a trigger press while a partial
reload has the magazine out plays fire_chamber_onehand: the gun
flicks to the hold one-handed, the bullet fires at the table's
fire_at, and the reload goes on dry from the insert. A switch during
the flick cancels the shot. A model without the sequence, the SRS,
and a gun with an empty chamber refuse the shot. The shot keeps the
reload's timers, animation and gesture. The cvar defaults to 0 until
every gun's model has the sequence; the weapon scripts carry the
sequence's phase tables, generated from segments.csv.

Every gun with a chamber now has its fire_chamber_onehand sequence,
so sv_neo_reload_chamber_shot defaults to 1.

After a shot the SRS chamber holds a spent case until the bolt cycle
brings the next round home, so the chamber icon dims at the shot and
lights when the bolt is home, with the magazine row dropping by one
then instead of at the shot. The moment comes from a "charge" phase
table in the weapon script (the Bolt bone home in the charge
sequence, frame 25). A quick switch or a reload cancels the bolt cycle
as before and the round counts as chambered. Ammo and fire timing are
unchanged.

The shot already racks the pump in the gun's state; the HUD now shows
the chamber dim and the fed round still in the tube until the fire
animation's pump is home, never later than the next shot is allowed.
The pump moments come from the weapon script (ChamberAfterShot 0.600
for a shell, ChamberAfterSlugShot 1.000 for a slug: the Pump bone home
in altfire f18 and fire f30). Ammo and fire timing are unchanged.

On a gun whose reload slaps or taps the magazine home, the trigger
now ends a partial reload only after the slap credit, not at the
seat, so a cancel skips only the steps already complete and stays
close to the full reload time. Guns without a slap still end at the
seat; the rule reads the reload's own phase table.